Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38947 )
Change subject: mb/hatch + soc/intel/cannonlake: Enable TetonGlacierMode on hatch ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/c/coreboot/+/38947/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38947/1//COMMIT_MSG@7 PS1, Line 7: mb/hatch + soc/intel/cannonlake: Enable TetonGlacierMode on hatch this should be two separate changes
https://review.coreboot.org/c/coreboot/+/38947/1//COMMIT_MSG@9 PS1, Line 9: reconfiguring the PCIe lanes at runtime for hybrid drives also mention, that fsp reconfigures clkreq accordingly, too
https://review.coreboot.org/c/coreboot/+/38947/1//COMMIT_MSG@9 PS1, Line 9: TetonGlacierMode maybe add "... hybrid drives likes 'Teton Glacier' (e.g. Optane Memory H10)"
https://review.coreboot.org/c/coreboot/+/38947/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38947/1/src/mainboard/google/hatch/... PS1, Line 53: and X2 NVMe this should be 'x4 NVMe and 2x2 NVMe'
https://review.coreboot.org/c/coreboot/+/38947/1/src/mainboard/google/hatch/... PS1, Line 176: 1( mising space
https://review.coreboot.org/c/coreboot/+/38947/1/src/mainboard/google/hatch/... PS1, Line 333: X2
x2
or better x4 / 2x2