Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33935 )
Change subject: mb/google/octopus: Add custom SAR values for Blooguard
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/33935/3/src/mainboard/google/octopus/variant...
File src/mainboard/google/octopus/variants/bloog/mainboard.c:
https://review.coreboot.org/#/c/33935/3/src/mainboard/google/octopus/variant...
PS3, Line 15:
Rename this file to variant.c since it is consistent with the naming convention within octopus.
Done
https://review.coreboot.org/#/c/33935/3/src/mainboard/google/octopus/variant...
PS3, Line 25: google_chromeec_cbi_get_sku_id
Use get_board_sku() instead of reaching out to EC. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33935
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id80df28a961eb1f62714558df2b219aa552ecb97
Gerrit-Change-Number: 33935
Gerrit-PatchSet: 5
Gerrit-Owner: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 02 Jul 2019 02:10:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment