Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33764 )
Change subject: soc/amd/picasso: Update all PSP and amdfw.rom building ......................................................................
Patch Set 11:
(4 comments)
https://review.coreboot.org/c/coreboot/+/33764/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33764/9//COMMIT_MSG@9 PS9, Line 9: comand
command
Done
https://review.coreboot.org/c/coreboot/+/33764/9//COMMIT_MSG@15 PS9, Line 15: See PID #55758.
Maybe: See AMD NDA document #55758
Done
https://review.coreboot.org/c/coreboot/+/33764/4/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/33764/4/src/soc/amd/picasso/Kconfig... PS4, Line 403: config PSP_WHITELIST_BL_FILE : string "Whitelist-capable bootloader file name" : depends on HAVE_PSP_WHITELIST_FILE : default "3rdparty/blobs/soc/amd/picasso/PSP/PspBootLoader_WL_RV.sbin"
I'm not yet sold that it should be removed. […]
Done
https://review.coreboot.org/c/coreboot/+/33764/9/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/33764/9/src/soc/amd/picasso/Kconfig... PS9, Line 397: t
Capitalize: "This"
Done