build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41894 )
Change subject: ec/google: Add function ec_fill_dptf_helpers()
......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41894/8/src/ec/google/chromeec/ec_d...
File src/ec/google/chromeec/ec_dptf_helpers.c:
https://review.coreboot.org/c/coreboot/+/41894/8/src/ec/google/chromeec/ec_d...
PS8, Line 17: TRIP_POINTS_CHANGED_EVENT = 0x81,
please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/41894/8/src/ec/google/chromeec/ec_d...
PS8, Line 18: THERMAL_EVENT = 0x90,
please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/41894/8/src/ec/google/chromeec/ec_d...
PS8, Line 23: EC_FAN_DUTY_AUTO = 0xFF,
please, no spaces at the start of a line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41894
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib30072d1d0748b31bcab240a0fd0e2f12d34aaa4
Gerrit-Change-Number: 41894
Gerrit-PatchSet: 8
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 05 Jun 2020 15:48:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment