Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35036 )
Change subject: drivers/generic: Add new driver for power resource pseudo device
......................................................................
Patch Set 7:
Patch Set 7:
I am still looking through the changes. But at minimum, I think we should split this CL into 3-4 separate changes:
- Refactoring of acpi_device_add_power_res(). Addition of acpi_add_power_states(), acpi_add_scoped_power_res(), acpigen_write_power_states() and update the callers.
- Change for scan_generic_bus()
- Addition of new driver for power resource
- Update current users of acpi_device_add_power_res() to use the new driver.
That sounds like a fine idea. I was debating how to split it
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35036
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I358c48f4d4e4c4ef591ecf09ea9e9488c2652c96
Gerrit-Change-Number: 35036
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 23 Aug 2019 00:28:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment