[coreboot-gerrit] Change in ...coreboot[master]: src/cpu/amd/pi/00730F01: Add microcode update infrastructure for fam1...

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29272 )

Change subject: src/cpu/amd/pi/00730F01: Add microcode update infrastructure for fam16h PI
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/29272/2/src/cpu/amd/pi/00730F01/microcode_fa... 
File src/cpu/amd/pi/00730F01/microcode_fam16h.c:

https://review.coreboot.org/#/c/29272/2/src/cpu/amd/pi/00730F01/microcode_fa... 
PS2, Line 130: #if IS_ENABLED(CONFIG_HAVE_ROMSTAGE_MICROCODE_CBFS_SPINLOCK)
#if CONFIG(...)

https://review.coreboot.org/#/c/29272/2/src/cpu/amd/pi/00730F01/microcode_fa... 
PS2, Line 150: 				   "updates.\n");
Missing spin_unlock() and return here?

Check for ucode_len > F16H_MPB_DATA_OFFSET to make sure there is at least some data, otherwise parsing the header is invalid access.