[coreboot-gerrit] Change in coreboot[master]: soc/intel: Fix regression with hidden PCI devices

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34285 )

Change subject: soc/intel: Fix regression with hidden PCI devices
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34285/7/src/device/device_const.c 
File src/device/device_const.c:

https://review.coreboot.org/c/coreboot/+/34285/7/src/device/device_const.c@2... 
PS7, Line 243: 	printk(BIOS_ERR, "BUG: %s requests hidden 00:%02x.%u\n", func, devfn >> 3, devfn & 7);
> Why is the dev getting returned NULL? It was in the static device tree right? why wouldn't the linka […]

I get it now. It's coming back to be w.r.t. the p2sb. However, that device is unhidden after fsp-s. So what code was causing a look up failure? A different device?