Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31502 )
Change subject: [WIP]device/pci_rom: Add ATRM method ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31502/1/src/device/pci_rom.c File src/device/pci_rom.c:
https://review.coreboot.org/#/c/31502/1/src/device/pci_rom.c@326 PS1, Line 326: acpigen_write_rom(cbrom, cbrom_length);
At least the AMD driver in linux doesn't need _ROM. […]
Ack, I thought it might be worth to keep _ROM for VGA devs only, but the spec really doesn't say what devices exactly.
I noticed, though, that it only applies to devices without a real ROM. But pci_rom_probe() would also return that? Should we bail out on non-onboard devices maybe?
https://review.coreboot.org/#/c/31502/1/src/device/pci_rom.c@328 PS1, Line 328: /* AMD uses ATRM. Redirect ATRM to _ROM */ This is run, too, on the primary VGA device. Intended?
I don't look through the whole thing yet. Is it allowed/ possible to make the AMD dGPU the primary VGA device?