Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37847 )
Change subject: Documentation/soc/amd: Add PSP integration information ......................................................................
Patch Set 4: Code-Review+1
(9 comments)
Some paragraphs could be reflowed.
https://review.coreboot.org/c/coreboot/+/37847/4/Documentation/soc/amd/psp_i... File Documentation/soc/amd/psp_integration.md:
https://review.coreboot.org/c/coreboot/+/37847/4/Documentation/soc/amd/psp_i... PS4, Line 15: system BIOS. Reflow on line above?
https://review.coreboot.org/c/coreboot/+/37847/4/Documentation/soc/amd/psp_i... PS4, Line 201: Bytes bytes
https://review.coreboot.org/c/coreboot/+/37847/4/Documentation/soc/amd/psp_i... PS4, Line 201: Every firmware binary contains 256 Bytes of a PSP Header, which includes : firmware version *the* firmware version?
https://review.coreboot.org/c/coreboot/+/37847/4/Documentation/soc/amd/psp_i... PS4, Line 239: "Region Type" Mark it up with ** so no quotes are needed?
https://review.coreboot.org/c/coreboot/+/37847/4/Documentation/soc/amd/psp_i... PS4, Line 338: **0x66**: x86 microcode patch Use microcode update patch?
https://review.coreboot.org/c/coreboot/+/37847/4/Documentation/soc/amd/psp_i... PS4, Line 351: cbfstool/amdcompress Mark up with ``?
https://review.coreboot.org/c/coreboot/+/37847/4/Documentation/soc/amd/psp_i... PS4, Line 354: elf ELF
https://review.coreboot.org/c/coreboot/+/37847/4/Documentation/soc/amd/psp_i... PS4, Line 364: amdfw.rom Mark up with ``?
https://review.coreboot.org/c/coreboot/+/37847/4/Documentation/soc/amd/psp_i... PS4, Line 368: "AMD Platform Security Processor BIOS Architecture : Design Guide for AMD Family 17h Processors" Mark up with ** instead of quotes.