Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik.
SH Kim has posted comments on this change by SH Kim. ( https://review.coreboot.org/c/coreboot/+/86377?usp=email )
Change subject: mb/google/nissa/var/meliks: Copy pirrha’s overridetree as initial one
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/brya/variants/meliks/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/86377/comment/560efdf5_a79701f6?usp... :
PS5, Line 269: probed
Done
Actually meliks uses a panel-built-in touch screen. This touch screen IC needs some delay after panel power up, so it may not be detected in coreboot phase.
Can we keep the `probed` for this special IC?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86377?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifd6dfbeca7276dbacd72f9145ed7119566c8faef
Gerrit-Change-Number: 86377
Gerrit-PatchSet: 6
Gerrit-Owner: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Thu, 20 Feb 2025 05:53:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: SH Kim
sh_.kim@samsung.corp-partner.google.com
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com