Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35225 )
Change subject: soc/intel/common/block/cse: Move me_read_config32() to common code
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35225/11/src/soc/intel/apollolake/c...
File src/soc/intel/apollolake/cse.c:
https://review.coreboot.org/c/coreboot/+/35225/11/src/soc/intel/apollolake/c...
PS11, Line 46: #define dump_status(index, hfs_reg) me_read_config32(hfs_reg)
you can remove dump_status from everywhere and just use me_read_config32.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35225
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icdbfb6b30a007d469b5e018a313c14586addb130
Gerrit-Change-Number: 35225
Gerrit-PatchSet: 11
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 09 Sep 2019 06:19:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment