Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38711 )
Change subject: util/ifdtool: Support modification of single Flash Descriptor ......................................................................
Patch Set 1: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/38711/1/util/ifdtool/ifdtool.c File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/38711/1/util/ifdtool/ifdtool.c@1340 PS1, Line 1340: module module isn't used in this context. Please use 'region'
https://review.coreboot.org/c/coreboot/+/38711/1/util/ifdtool/ifdtool.c@1344 PS1, Line 1344: module Remove
https://review.coreboot.org/c/coreboot/+/38711/1/util/ifdtool/ifdtool.c@1346 PS1, Line 1346: descriptor_only Setting new_extent = size here should make descriptor_only obsolescent
https://review.coreboot.org/c/coreboot/+/38711/1/util/ifdtool/ifdtool.c@1381 PS1, Line 1381: Descriptor Skipping descriptor