Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40501 )
Change subject: deltaur: Split up chromeos.fmd ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Patch Set 1:
LGTM, but this will add little complexity of ME re-packing and coreboot-private files. GBE region is no harm if we add it but not use it. Like Arcada doesn't have onboard LAN but we still add GBE for it.
Agreed, that could be a bit troublesome.
https://review.coreboot.org/c/coreboot/+/40501/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40501/1//COMMIT_MSG@7 PS1, Line 7: deltaur: Split up chromeos.fmd
I’d describe the change in the summary, and not how it’s accomplished. Maybe: […]
That would be incorrect, though. The GbE region is not removed, the fmap is split into two in order to have both possibilities. This is needed as future variants may or may not use GbE.
https://review.coreboot.org/c/coreboot/+/40501/1//COMMIT_MSG@9 PS1, Line 9: Deltan will use the GbE region, whereas deltaur will not.
Why doesn’t it need the GbE region?
Most likely, design considerations. Not every board uses the Intel GbE controller inside the PCH.