Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38081 )
Change subject: mb/hp/*/devicetree.cb: Inherit the subsystemid ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38081/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38081/1//COMMIT_MSG@9 PS1, Line 9: Since the same subsystemid is used for all the devices on the
This is not true, some were left at their default.
Seems to be unintentional, though. Suggestions to reword this?
https://review.coreboot.org/c/coreboot/+/38081/1/src/mainboard/hp/2760p/devi... File src/mainboard/hp/2760p/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38081/1/src/mainboard/hp/2760p/devi... PS1, Line 78: device pci 1c.3 on end # WLAN
Didn't have a subsystem id before.
Why shouldn't it? In any case, there are no fixups associated with Subsystem ID `0x162a` in Linux:
https://github.com/torvalds/linux/search?q=0x162a&unscoped_q=0x162a
https://review.coreboot.org/c/coreboot/+/38081/1/src/mainboard/hp/2760p/devi... PS1, Line 81: device pci 1c.6 on end # PCIe Port #7, WWAN
Didn't either.
See (and discuss) above
https://review.coreboot.org/c/coreboot/+/38081/1/src/mainboard/hp/8770w/devi... File src/mainboard/hp/8770w/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38081/1/src/mainboard/hp/8770w/devi... PS1, Line 36: device pci 00.0 on end # GPU : device pci 00.1 on end # HDMI Audio on GPU
Note, these inherit the sid too, intended?
Yes, the kernel has code for some GPUs with Subvendor ID `0x103c`:
https://github.com/torvalds/linux/search?q=0x103c&unscoped_q=0x103c
However, no fixups for Subsystem ID `0x176c`:
https://github.com/torvalds/linux/search?q=0x176c&unscoped_q=0x176c