Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48174 )
Change subject: drivers/intel/fsp2_0: Fix running on x86_64
......................................................................
Patch Set 8:
(4 comments)
https://review.coreboot.org/c/coreboot/+/48174/5/src/drivers/intel/fsp2_0/Kc...
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/48174/5/src/drivers/intel/fsp2_0/Kc...
PS5, Line 36: default y
It was really more of a Kconfig question. […]
Removed the explicit select.
https://review.coreboot.org/c/coreboot/+/48174/5/src/drivers/intel/fsp2_0/Kc...
PS5, Line 40: config PLATFORM_USES_FSP2_X86_64
It looks like this is currently unused and could removed. […]
Removed for now.
https://review.coreboot.org/c/coreboot/+/48174/5/src/drivers/intel/fsp2_0/in...
File src/drivers/intel/fsp2_0/include/fsp/info_header.h:
https://review.coreboot.org/c/coreboot/+/48174/5/src/drivers/intel/fsp2_0/in...
PS5, Line 39: #else
No, it looks important and surely wouldn't work right if you removed it. […]
Removed for now as no such spec exists.
https://review.coreboot.org/c/coreboot/+/48174/7/src/soc/intel/elkhartlake/K...
File src/soc/intel/elkhartlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/48174/7/src/soc/intel/elkhartlake/K...
PS7, Line 33: 2_2
did you mean to change this one?
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48174
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6015005c4ee3fc2f361985cf8cff896bcefd04fb
Gerrit-Change-Number: 48174
Gerrit-PatchSet: 8
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Michal Motyl
michalx.motyl@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 08 Dec 2020 09:11:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment