Attention is currently required from: Nico Huber, Nikolai Vyssotski. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49867 )
Change subject: soc/amd/common/block/graphics/graphics: GOP: pass VBIOS to FSP/VFCT ......................................................................
Patch Set 10:
(5 comments)
File src/soc/amd/common/block/graphics/graphics.c:
https://review.coreboot.org/c/coreboot/+/49867/comment/b03494d4_2f64d9b3 PS10, Line 138: nit: extra newline
https://review.coreboot.org/c/coreboot/+/49867/comment/d61937af_a45208da PS10, Line 140: memset((void *)&vbios_buffer, 0, sizeof(vbios_buffer)); Should already be initialized to 0, so you can skip this.
https://review.coreboot.org/c/coreboot/+/49867/comment/aa2fb2da_f7a8cd14 PS10, Line 164: copy_vbios(dev Do we need to copy the vbios, or can we return the rom pointer? it should be a spi mmaped address.
https://review.coreboot.org/c/coreboot/+/49867/comment/d4001a64_bbb5b1fb PS10, Line 168: gop_pci_rom_acpi_fill_vfct I guess I'm missing something. Does FSP modify the vbios_buffer?
Why can't we use pci_rom_write_acpi_tables and pci_rom_acpi_fill_vfct?
File src/soc/amd/picasso/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/49867/comment/ca23c3ba_c1e0ab24 PS10, Line 131: Was this intentional?