Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32308 )
Change subject: smbios: Walk over PCI devicetree to fill type 9
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/32308/4/src/arch/x86/smbios.c
File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/32308/4/src/arch/x86/smbios.c@1057
PS4, Line 1057: dev->path.pci.devfn);
Maybe move it into its own function? You'd just call it here with
`current`, `handle` and `dev` and a `continue;` would become an
early `return;`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32308
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1961d8af2d21f755ff52ad58804ea9b31d2a5b9b
Gerrit-Change-Number: 32308
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Fri, 26 Apr 2019 15:17:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment