Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31834 )
Change subject: ec/google/chromeec: Support AP watchdog flag from Chrome EC ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/31834/3/src/ec/google/chromeec/Kconfig File src/ec/google/chromeec/Kconfig:
https://review.coreboot.org/#/c/31834/3/src/ec/google/chromeec/Kconfig@27 PS3, Line 27: config EC_GOOGLE_CHROMEEC_AP_WATCHDOG_FLAG This should probably be somewhere in soc/mediatek, not here.
https://review.coreboot.org/#/c/31834/3/src/ec/google/chromeec/ec.c File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/#/c/31834/3/src/ec/google/chromeec/ec.c@39 PS3, Line 39: #define RESET_FLAG_AP_WATCHDOG (1 << 18) /* AP experienced a watchdog reset */ Is this not in ec_command.h? Sounds like it should be...