Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44293 )
Change subject: drivers/amd/agesa/s3_mtrr.c: Use a struct over pointer aritmetic
......................................................................
Patch Set 4:
(1 comment)
File src/drivers/amd/agesa/s3_mtrr.c:
https://review.coreboot.org/c/coreboot/+/44293/comment/0b40c753_7982ad9d
PS4, Line 10:
: struct mtrr_backup {
: msr_t mtrr_fix_64k_00000;
: msr_t mtrr_fix_16k_80000;
: msr_t mtrr_fix_16k_a0000;
: msr_t mtrr_fix_4k_xx000[8]; /* 4K_C0000 -- 4K_F8000 */
: msr_t mtrr_phys_base[8];
: msr_t mtrr_phys_mask[8];
: msr_t syscfg;
: msr_t top_mem;
: msr_t top_mem2;
: };
The code probably looks a lot simpler using a MSR address array.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44293
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3c6df8951d39695cddd4635360d6407d4d001b0a
Gerrit-Change-Number: 44293
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-CC: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Wed, 18 May 2022 12:13:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment