Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33993 )
Change subject: mainboard/amd: Add padmelon board code ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/#/c/33993/1/src/mainboard/amd/padmelon/fan_init.... File src/mainboard/amd/padmelon/fan_init.c:
https://review.coreboot.org/#/c/33993/1/src/mainboard/amd/padmelon/fan_init.... PS1, Line 29: [] [FINTEK_BOUNDARIES_SIZE]
https://review.coreboot.org/#/c/33993/1/src/mainboard/amd/padmelon/fan_init.... PS1, Line 36: [] same here
https://review.coreboot.org/#/c/33993/1/src/mainboard/amd/padmelon/fan_init.... PS1, Line 43: [] [FINTEK_SECTIONS_SIZE]
https://review.coreboot.org/#/c/33993/1/src/mainboard/amd/padmelon/fan_init.... PS1, Line 51: [] same here
https://review.coreboot.org/#/c/33993/1/src/mainboard/amd/padmelon/fan_init.... PS1, Line 112: static void init_hwm(void) this shouldn't be done here