Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40141 )
Change subject: Kill the dead_code macro
......................................................................
Patch Set 5: Code-Review-1
Yeah I'm not saying it isn't, but let's just fix it rather than remove it immediately?
That's one reason why the hotfix was fast-path merged and not removal. also because the hotfix was less invasive
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40141
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06f825e045d3305dd8ab81311fd2d003d03ae43a
Gerrit-Change-Number: 40141
Gerrit-PatchSet: 5
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 06 Apr 2020 20:56:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment