Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44135 )
Change subject: mb/google/zork: keep the c-state IO base address alignment
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/44135/5/src/soc/amd/picasso/include...
File src/soc/amd/picasso/include/soc/iomap.h:
https://review.coreboot.org/c/coreboot/+/44135/5/src/soc/amd/picasso/include...
PS5, Line 66: 0x413
I think Felix wanted this to be the offset from PICASSO_ACPI_IO_BASE:
https://review.coreboot.org/c/coreboot/+/44135/4/src/soc/amd/picasso/include...
changing the original line 72's offset of 0x0c to 0x13 would suffice in conjunction w/ the other .c file changes.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44135
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib98d34af518439d338326446c20601867ad31690
Gerrit-Change-Number: 44135
Gerrit-PatchSet: 5
Gerrit-Owner: chris wang
Chris.Wang@amd.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 05 Aug 2020 04:42:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment