Attention is currently required from: Dolan Liu, Jianeng Ceng, Nick Vaccaro, Paul Menzel, Reka Norman, Shou-Chieh Hsu, Subrata Banik.
Weimin Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79164?usp=email )
Change subject: mb/google/nissa/var/anraggar: Enable ILITEK touchscreen
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79164/comment/94078a1c_651e9ac4 :
PS3, Line 9: Fix GPP_C6 configration for ILITEK touchscreen.
… according to schematics?
Yes, according to SCH and verified on proto PCB.
https://review.coreboot.org/c/coreboot/+/79164/comment/c7cff756_13b340eb :
PS3, Line 9: Fix GPP_C6 configration for ILITEK touchscreen.
Should the touchscreen have worked before, and just wasn’t tested?
This is initialization code, now verified on proto PCB.
File src/mainboard/google/brya/variants/anraggar/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/79164/comment/65e4c098_69f9284f :
PS3, Line 227: register "generic.stop_off_delay_ms" = "2"
Please note in the commit message why you remove it.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79164?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7dabf205dba616f57ef9717f950eba96282d8e3d
Gerrit-Change-Number: 79164
Gerrit-PatchSet: 4
Gerrit-Owner: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: Dolan Liu
liuyong5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jianeng Ceng
cengjianeng@huaqin.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Dolan Liu
liuyong5@huaqin.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Attention: Jianeng Ceng
cengjianeng@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Mon, 27 Nov 2023 15:49:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment