24 Dec
2019
24 Dec
'19
12:08 a.m.
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37649 )
Change subject: mb/google/octopus/variants/bobba: fix LTE power sequence ......................................................................
Patch Set 3:
Hi Sheng-Liang, are you able to address the comment from Karthik? I think one benefit to use get_board_sku() is that we don't need to communicate to EC again if we did it once. Thanks.
--
To view, visit https://review.coreboot.org/c/coreboot/+/37649
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I287ba1cb092a95b3a9dd1f960a3b84fd85b9b221
Gerrit-Change-Number: 37649
Gerrit-PatchSet: 3
Gerrit-Owner: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: Henry Sun henrysun@google.com
Gerrit-Reviewer: Justin TerAvest teravest@chromium.org
Gerrit-Reviewer: Marco Chen marcochen@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian kramasub@google.com
Gerrit-CC: Ren Kuo ren.kuo@quanta.corp-partner.google.com
Gerrit-Comment-Date: Tue, 24 Dec 2019 08:08:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment