Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48764 )
Change subject: [WIP] 3rdparty/libgfxinit: Update for Cannon Point support ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/48764/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48764/1//COMMIT_MSG@10 PS1, Line 10: Hence, libgfxinit : has a new Kconfig setting now for the PCH. I'd move `now` earlier in the sentence:
Hence, libgfxinit *now* has a new Kconfig setting for the PCH.
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... PS1, Line 128: default "Cannon_Point" if SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE Does `Cannon_Point` also apply to SOC_INTEL_COMETLAKE ?