Attention is currently required from: Reagan.
Nico Huber has posted comments on this change by Reagan. ( https://review.coreboot.org/c/coreboot/+/82458?usp=email )
Change subject: mb/razer/blade_stealth_kbl: add panel_cfg ......................................................................
Patch Set 13:
(1 comment)
File src/mainboard/razer/blade_stealth_kbl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/82458/comment/1c4fe137_3cb190f6?usp... : PS13, Line 163: .backlight_off_delay_ms = 5000, /* T12 */ Alas, the VBT values are not in *ms*. I think it's 1/10th of a ms (most hardware registers use multiples of 100us). And the mapping is wrong. The actual sequence is: 1. power up the panel 2. after T3, configure the panel 3. start video output 4. after T7, enable the backlight (so nobody sees things glitch) ... 5. eventually power down the backlight, wait for T9 6. stop video output 7. after T10, power down the panel ... 8. before powering up again, make sure T12 passed
You can also confirm the used values, comparing the register values read with `intel_reg`. To make sure you have the devicetree values in Linux, boot *without* a VBT. cf. https://doc.coreboot.org/gfx/display-panel.html