Attention is currently required from: David Wu, Evan Green, Paul Menzel, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55249 )
Change subject: mb/google/dedede/var/metaknight: Turn off lte power when s0ix
......................................................................
Patch Set 6:
(2 comments)
File src/mainboard/google/dedede/variants/metaknight/include/variant/acpi/lte.asl:
https://review.coreboot.org/c/coreboot/+/55249/comment/9f41b7e1_fbff2198
PS6, Line 3: LTE_EN
What does EN mean?
EN = ENable
https://review.coreboot.org/c/coreboot/+/55249/comment/3f84d5bd_d9e7479c
PS6, Line 8: If (Arg0) {
Is there a way to check in ACPI/ASL, if the device is present?
The only way (currently) would be to add FW_CONFIG support to ACPI, which is not planned. Instead, dedede added a `VARIANT_HAS_LTE_ACPI` Kconfig option to add this power sequencing to the variants that have an LTE modem.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55249
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78a39d8cd7a348ad36be9b5969f5c75ed48df833
Gerrit-Change-Number: 55249
Gerrit-PatchSet: 6
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Evan Green
evgreen@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 07 Jun 2021 14:18:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment