Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39860 )
Change subject: soc/intel/tigerlake: Allow mainboard to override DRAM part number
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39860/7/src/soc/intel/tigerlake/rom...
File src/soc/intel/tigerlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/39860/7/src/soc/intel/tigerlake/rom...
PS7, Line 39: return false;
Print out a debug message, that the weak implementation was used?
This function is not the one designed for every board to implement so it might be not needed to print the warning as I understand.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39860
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If940a76d36a7645a7441ba418aa7aec9af9f6319
Gerrit-Change-Number: 39860
Gerrit-PatchSet: 7
Gerrit-Owner: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 01 Apr 2020 08:40:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment