Attention is currently required from: chris wang.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44135 )
Change subject: mb/google/zork: keep the c-state IO base address alignment
......................................................................
Patch Set 7:
(1 comment)
File src/soc/amd/picasso/include/soc/iomap.h:
https://review.coreboot.org/c/coreboot/+/44135/comment/53572231_b1239479
PS7, Line 72: 0x13
the 0x13 does look a bit odd to me and the reference code has an offset of 0x10 here in version 1.0.0.c. i'd say that it would be good to align this with the reference code, but i'm not 100% sure how to test it this still works properly after the change
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44135
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib98d34af518439d338326446c20601867ad31690
Gerrit-Change-Number: 44135
Gerrit-PatchSet: 7
Gerrit-Owner: chris wang
Chris.Wang@amd.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: chris wang
Chris.Wang@amd.com
Gerrit-Comment-Date: Wed, 03 Feb 2021 18:53:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment