Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39345 )
Change subject: mb/google/volteer: Enable DPTF functionality
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39345/7/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/39345/7/src/mainboard/google/voltee...
PS7, Line 4: * Copyright (C) 2020 Intel Corporation.
No dot at the end.
https://review.coreboot.org/c/coreboot/+/39345/7/src/mainboard/google/voltee...
PS7, Line 42: #define DPTF_TSR1_ACTIVE_AC4 39
Use tabs consistently for alignment. Please be more careful of these things.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39345
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iccd387d78bb45ca3de73f531a901d1d3f793d7bd
Gerrit-Change-Number: 39345
Gerrit-PatchSet: 7
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Roy Mingi Park
roy.mingi.park@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Puthikorn Voravootivat
puthik@chromium.org
Gerrit-CC: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Comment-Date: Fri, 20 Mar 2020 16:55:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment