You-Cheng Syu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31516 )
Change subject: google/kukui: boot up sspm ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/#/c/31516/1/src/mainboard/google/kukui/Makefile.... File src/mainboard/google/kukui/Makefile.inc:
https://review.coreboot.org/#/c/31516/1/src/mainboard/google/kukui/Makefile.... PS1, Line 32: =$ insert a space character
https://review.coreboot.org/#/c/31516/1/src/mainboard/google/kukui/mainboard... File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/#/c/31516/1/src/mainboard/google/kukui/mainboard... PS1, Line 16: #include <console/console.h> : #include <cbfs.h> : #include <device/device.h> : #include <soc/gpio.h> : #include <soc/mmu_operations.h> : #include <soc/usb.h> : #include <soc/sspm.h> sort include lines
https://review.coreboot.org/#/c/31516/1/src/mainboard/google/kukui/mainboard... PS1, Line 44: unsigned char buf[BUF_SIZE]; move this array into sspm_boot()
https://review.coreboot.org/#/c/31516/1/src/mainboard/google/kukui/mainboard... PS1, Line 48: "sspm" Don't directly use string literal as file name.
https://review.coreboot.org/#/c/31516/1/src/soc/mediatek/mt8183/Makefile.inc File src/soc/mediatek/mt8183/Makefile.inc:
https://review.coreboot.org/#/c/31516/1/src/soc/mediatek/mt8183/Makefile.inc... PS1, Line 52: ramstage-y += sspm.c move this line in between line 47~48
https://review.coreboot.org/#/c/31516/1/src/soc/mediatek/mt8183/include/soc/... File src/soc/mediatek/mt8183/include/soc/sspm.h:
https://review.coreboot.org/#/c/31516/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 26: #define CFG_SSPM_SRAM 0x10400000 move this line in between line 20~22