Attention is currently required from: Angel Pons, Kyösti Mälkki, Patrick Rudolph. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59008 )
Change subject: mb/google,samsung: Drop init_bootmode_straps() ......................................................................
Patch Set 4: Code-Review+2
(2 comments)
File src/include/bootmode.h:
https://review.coreboot.org/c/coreboot/+/59008/comment/57099f3f_eb411973 PS2, Line 19: void stash_bootmode(int flag_spi_wp, int flag_rec_mode);
At least for samsung/lumpy, rec mode switch is momentary push button. […]
IIRC our official instructions to users have always been "hold down the recovery button until you see the recovery screen appear", so they should really be no reason to read it in romstage vs. ramstage.
File src/mainboard/google/beltino/chromeos.c:
https://review.coreboot.org/c/coreboot/+/59008/comment/b919984e_11b1014a PS3, Line 16: !get_recovery_mode_switch(), "presence"},
Does the initial state sampled late in ramstage have any significance? We're adding an actual GPIO p […]
In depthcharge, for GPIO_REC_MODE we only ever cared about the value that was sampled by coreboot -- we ignored the actual GPIO pin info. Depthcharge used to differentiate between GPIOs that should get resampled at runtime (like "lid", "power", "EC in RW") and those where it just uses the value from coreboot (like "recovery" or "write protect") because they're not expected to change in the middle of a single boot. Today we don't use most of these GPIOs anymore and I believe only the former category is left in practice on the boards we still support in depthcharge ToT.
However, for boards that still booted u-boot (if we still care about having ToT coreboot stay compatible to that), I don't know what it did with each pin.