Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34423 )
Change subject: soc/amd/picasso: Add FSP support for including AGESA ......................................................................
Patch Set 14:
(3 comments)
Some nits
https://review.coreboot.org/c/coreboot/+/34423/14//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34423/14//COMMIT_MSG@12 PS14, Line 12: easili easily
https://review.coreboot.org/c/coreboot/+/34423/14/src/soc/amd/picasso/reset.... File src/soc/amd/picasso/reset.c:
https://review.coreboot.org/c/coreboot/+/34423/14/src/soc/amd/picasso/reset.... PS14, Line 65: printk(BIOS_ERR, "Error: unexpected call to %s(0x%08x). Doing cold reset.\n", : __func__, status); could we move this above the assert so that when we have fatal asserts turned on we git this output?
https://review.coreboot.org/c/coreboot/+/34423/14/src/soc/amd/picasso/romsta... File src/soc/amd/picasso/romstage.c:
https://review.coreboot.org/c/coreboot/+/34423/14/src/soc/amd/picasso/romsta... PS14, Line 114: alone*/ Add space between alone and */