Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45341 )
Change subject: soc/intel/common/block/cse: Add helper function cse_send_global_reset ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45341/1/src/soc/intel/common/block/... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/45341/1/src/soc/intel/common/block/... PS1, Line 666: cse_send_global_reset
It is not very clear to me what the intention of adding this function is. […]
The purpose of this is to unify reset handling across SoCs. But I agree, this should just be a mere wrapper for `cse_request_reset`. If any checks are done here, why not do them for all reset types?