Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43628 )
Change subject: mb/system76/lemp9: enable SA thermal device
......................................................................
Patch Set 19:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43628/19/src/mainboard/system76/lem...
File src/mainboard/system76/lemp9/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43628/19/src/mainboard/system76/lem...
PS19, Line 142: register "Device4Enable" = "1"
Please move this down to the devicetree.
https://review.coreboot.org/c/coreboot/+/43628/19/src/mainboard/system76/lem...
PS19, Line 195: device pci 04.0 on end # SA Thermal device
```
device pci 04.0 on # SA Thermal device
register "Device4Enable" = "1"
end
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43628
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I527e586b1dae5f8087d2364c63c9db5bcb643214
Gerrit-Change-Number: 43628
Gerrit-PatchSet: 19
Gerrit-Owner: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Comment-Date: Sun, 26 Jul 2020 20:01:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment