Attention is currently required from: Sean Rhodes, Paul Menzel.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62702 )
Change subject: ec/starlabs/merlin: Add support for Nuvoton EC's
......................................................................
Patch Set 12: Code-Review+1
(2 comments)
File src/ec/starlabs/merlin/nuvoton.c:
https://review.coreboot.org/c/coreboot/+/62702/comment/d86cf623_34052a41
PS12, Line 132: EC_STARLABS_MAX_CHARGE
Please revise Kconfig dependencies
https://review.coreboot.org/c/coreboot/+/62702/comment/4d568811_031d5656
PS12, Line 154: EC_STARLABS_FAN
Please revise Kconfig dependencies
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62702
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib66baf1e88f5d548ce955dffa00c9b88255b2f95
Gerrit-Change-Number: 62702
Gerrit-PatchSet: 12
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Mon, 28 Mar 2022 22:48:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment