Petr Cvek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35671 )
Change subject: mb/kontron/986lcd-m: Add gameport base allocation workaround
......................................................................
Patch Set 2:
(1 comment)
added comment about workaround
https://review.coreboot.org/c/coreboot/+/35671/1/src/mainboard/kontron/986lc...
File src/mainboard/kontron/986lcd-m/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35671/1/src/mainboard/kontron/986lc...
PS1, Line 82: io 0x60 = 0x220
maybe add a comment that this is a workaround for the allocator?
fixed, along with the commit message
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35671
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie8e42552ac5e638e91e5c290655edcce1f64e408
Gerrit-Change-Number: 35671
Gerrit-PatchSet: 2
Gerrit-Owner: Petr Cvek
petrcvekcz@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Petr Cvek
petrcvekcz@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 30 Sep 2019 23:50:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment