15 Aug
2019
15 Aug
'19
4:49 a.m.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27416 )
Change subject: mediatek: Share GPIO code among similar SOCs ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/27416/6/src/soc/mediatek/common/gpi... File src/soc/mediatek/common/gpio.c:
https://review.coreboot.org/c/coreboot/+/27416/6/src/soc/mediatek/common/gpi... PS6, Line 53: write32(reg, 1L << bit); Why don't we have to use 'clrsetbits_le32()' to avoid clearing other bits?
--
To view, visit https://review.coreboot.org/c/coreboot/+/27416
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icdd1f2a1dd1bd64a7218bf9c63bd4a0af1acbcc0
Gerrit-Change-Number: 27416
Gerrit-PatchSet: 6
Gerrit-Owner: Tristan Hsieh tristan.shieh@mediatek.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Joel Kitching kitching@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Ting Shen phoenixshen@google.com
Gerrit-Reviewer: Tristan Hsieh tristan.shieh@mediatek.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Yu-Ping Wu yupingso@google.com
Gerrit-Comment-Date: Thu, 15 Aug 2019 02:49:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment