Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35014 )
Change subject: Move and rename ARCH_STAGE_HAS_xxx_SECTION rules
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35014/5/src/include/rules.h
File src/include/rules.h:
https://review.coreboot.org/c/coreboot/+/35014/5/src/include/rules.h@297
PS5, Line 297: defined(__PRE_RAM__)
Should this be updated to ENV_CACHE_AS_RAM as well may be in a follow-up CL?
I see this is already done in a follow-up CL.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35014
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I95a56dbad3482202f6cc03043589bebfb13c39af
Gerrit-Change-Number: 35014
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Fri, 23 Aug 2019 02:39:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment