Attention is currently required from: Jason Glenesk, Marshall Dawson, Paul Menzel, Zheng Bao, Patrick Huang, Felix Held.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61260 )
Change subject: mb/google/guybrush/dewatt: Add variant to disable HDMI
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/google/guybrush/variants/dewatt/variant.c:
https://review.coreboot.org/c/coreboot/+/61260/comment/b2cd4609_9cab0547
PS7, Line 8: if ((get_cpu_count() == 4 && get_threads_per_core() == 2) || get_cpu_count() == 2)
Please explain that heuristic in the commit message.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61260
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d0fa96818a768b7960d92821b927dbc622675ae
Gerrit-Change-Number: 61260
Gerrit-PatchSet: 7
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Patrick Huang
patrick.huang@amd.corp-partner.google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Patrick Huang
patrick.huang@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 25 Jan 2022 14:11:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment