Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41598 )
Change subject: Makefile: Use SPDX identifier
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/41598/1/Makefile
File Makefile:
https://review.coreboot.org/c/coreboot/+/41598/1/Makefile@1
PS1, Line 1: # SPDX-License-Identifier: BSD-3-Clause
That's what Makefile.inc uses and I just copied that. […]
well, C and Ada comments start with two characters, so I'd use two as well to be consistent
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41598
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia05f2ecd31d0606dfe2bca843dbe6df2b8212a27
Gerrit-Change-Number: 41598
Gerrit-PatchSet: 2
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 21 May 2020 18:31:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Jacob Garber
jgarber1@ualberta.ca
Gerrit-MessageType: comment