Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38044 )
Change subject: amd_blobs: Always set default paths
......................................................................
Patch Set 1:
Maybe I don't quite understand the intent behind this. Are you saying you want to force a build error when !USE_AMD_BLOBS && !(user setting CONFIG_ path strings)? Right now the Makefile.inc interprets empty strings as absence of the blobs and builds/runs OK with warning messages. My initial impression is that I would prefer it stay as-is.
AFAICS, the abuild problem should be solved without this change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38044
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I754fdc5e1414c8a3dc88b364bcfbea9a26b59eb0
Gerrit-Change-Number: 38044
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 02 Jan 2020 22:33:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment