Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32511 )
Change subject: WIP: google/kukui: Elaborate panel support for Kukui family boards. ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/#/c/32511/8/src/mainboard/google/kukui/Makefile.... File src/mainboard/google/kukui/Makefile.inc:
https://review.coreboot.org/#/c/32511/8/src/mainboard/google/kukui/Makefile.... PS8, Line 26: y $(CONFIG_BOARD_GOOGLE_KUKUI)
https://review.coreboot.org/#/c/32511/8/src/mainboard/google/kukui/display.c File src/mainboard/google/kukui/display.c:
https://review.coreboot.org/#/c/32511/8/src/mainboard/google/kukui/display.c... PS8, Line 98: if (CONFIG(BOARD_GOOGLE_KUKUI)) : return &kukui_display_intf; : else : return NULL; This implies we'll need to include all interfaces for any builds. I think the right way is to move this into panel_$board.c, so kukui will only have config for kukui.