Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86381?usp=email )
Change subject: mb/google/rauru: Add GPIO_AP_SUSPEND_L initial setting
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86381/comment/a7c351ea_3dc20e2f?usp... :
PS3, Line 7: mb/google/rauru: Add EC suspend pin initial setting
:
: Set the EC suspend pin to output high.
mb/google/rarur: Configure AP_IN_SLEEP_L pin […]
Done
File src/mainboard/google/rauru/gpio.h:
https://review.coreboot.org/c/coreboot/+/86381/comment/2d28c6a1_6faa5195?usp... :
PS3, Line 17: GPIO_EC_SUSPEND_PIN
`GPIO_AP_SUSPEND_L`. Please always follow the naming on the schematic.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86381?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6ea56208256bb6f11fb6b0adf7627403963295bc
Gerrit-Change-Number: 86381
Gerrit-PatchSet: 5
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 13 Feb 2025 06:13:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin
yidilin@google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com