[coreboot-gerrit] Change in em100[master]: em100: Detect emulated flash chip

[Simon Glass (Code Review)]

Simon Glass has posted comments on this change. ( https://review.coreboot.org/c/em100/+/35947 )

Change subject: em100: Detect emulated flash chip
......................................................................

Patch Set 3:

(6 comments)

https://review.coreboot.org/c/em100/+/35947/3/em100.c 
File em100.c:

https://review.coreboot.org/c/em100/+/35947/3/em100.c@573 
PS3, Line 573:  *
This is good but please also document the args

@desc: ...
@reg1: ..
@out: Returns ...

https://review.coreboot.org/c/em100/+/35947/3/em100.c@579 
PS3, Line 579: uint16_t
I feel this could be int or unsigned int. It doesn't need to be a 16-bit int

https://review.coreboot.org/c/em100/+/35947/3/em100.c@581 
PS3, Line 581: int
blank line after decl

https://review.coreboot.org/c/em100/+/35947/3/em100.c@588 
PS3, Line 588: return
blank line before return

https://review.coreboot.org/c/em100/+/35947/3/em100.c@595 
PS3, Line 595:  *
Please document args

https://review.coreboot.org/c/em100/+/35947/3/em100.c@611 
PS3, Line 611: 		uint16_t comp;
blank line after decl