Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34159 )
Change subject: mb/intel/coffeelake_rvp: Fix display issues on CFL-H, CFL-S, WHL Intel RVP ......................................................................
Patch Set 4:
(7 comments)
Please split the commit into two, as the two changes seem to be fixing separate issues.
https://review.coreboot.org/c/coreboot/+/34159/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34159/4//COMMIT_MSG@6 PS4, Line 6: : mb/intel/coffeelake_rvp: Fix display issues on CFL-H, CFL-S, WHL : Intel RVP The summary has to fit on one line.
https://review.coreboot.org/c/coreboot/+/34159/4//COMMIT_MSG@11 PS4, Line 11: not showing up in UEFI shell So nothing is displayed or UEFI shell has a command to list the found displays?
https://review.coreboot.org/c/coreboot/+/34159/4//COMMIT_MSG@11 PS4, Line 11: are is
https://review.coreboot.org/c/coreboot/+/34159/4//COMMIT_MSG@12 PS4, Line 12: DDi DDI?
https://review.coreboot.org/c/coreboot/+/34159/4//COMMIT_MSG@14 PS4, Line 14: UEFI : Payload Which one? TianoCore?
https://review.coreboot.org/c/coreboot/+/34159/4//COMMIT_MSG@15 PS4, Line 15: Payload payload
https://review.coreboot.org/c/coreboot/+/34159/4//COMMIT_MSG@18 PS4, Line 18: This issue is fixed by programming eDP GPIO's in bootblock stage and Please add a blank line above, or do not break the line.