[coreboot-gerrit] Change in coreboot[master]: soc/mediatek/mt8183: Run DRAM full calibration

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35110 )

Change subject: soc/mediatek/mt8183: Run DRAM full calibration
......................................................................

Patch Set 50:

(2 comments)

https://review.coreboot.org/c/coreboot/+/35110/50/src/mainboard/google/kukui... 
File src/mainboard/google/kukui/romstage.c:

https://review.coreboot.org/c/coreboot/+/35110/50/src/mainboard/google/kukui... 
PS50, Line 48: assert(length <= CALIBRATION_REGION_SIZE);
this is no longer needed since we have the _Static_assert.

https://review.coreboot.org/c/coreboot/+/35110/50/src/mainboard/google/kukui... 
PS50, Line 64: .get_sdram_config = &get_sdram_config,
hmmm, given that this is already defined in soc/sdram_configs.h, I think we don't need to pass it from mainboard implementation, unless if you have good reasons (for example you have to use same function in mtk-dramk blob, or you think this will be not calling SOC's get_sdram_config in some case.