24 Oct
2020
24 Oct
'20
1:26 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46682 )
Change subject: nb/intel/haswell/finalize.c: Align with Broadwell ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46682/4/src/northbridge/intel/haswe... File src/northbridge/intel/haswell/finalize.c:
https://review.coreboot.org/c/coreboot/+/46682/4/src/northbridge/intel/haswe... PS4, Line 28: 1UL
When unifying this with BDW later, please use `1u` or just `1`. UL is […]
Agreed. I can change this in a reproducible manner.
--
To view, visit https://review.coreboot.org/c/coreboot/+/46682
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe15c2598fabda752c9a54eba6362621e144ad77
Gerrit-Change-Number: 46682
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 24 Oct 2020 10:26:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment