Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48764 )
Change subject: [WIP] 3rdparty/libgfxinit: Update for Cannon Point support ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48764/1/3rdparty/libgfxinit File 3rdparty/libgfxinit:
https://review.coreboot.org/c/coreboot/+/48764/1/3rdparty/libgfxinit@1 PS1, Line 1: b9e792ee73407d
should be e2c57a60aa8d774039ebb2e9929a6028c8233fa3 / CB:48770
The correct hash can only be known once the libgfxinit changes are merged. This is why there's [WIP] labels in the commit message.
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... PS1, Line 127: SOC_INTEL_SKYLAKE || SOC_INTEL_KABYLAKE
SOC_INTEL_COMMON_SKYLAKE_BASE
I'd prefer to leave this as-is on this patch, and change this instance and the one for GFX_GMA_GENERATION in a follow-up.