Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45320 )
Change subject: soc/intel/common/block: Use pci_dev_request_bus_master for BM enabling ......................................................................
soc/intel/common/block: Use pci_dev_request_bus_master for BM enabling
Replace static sata_final() implementation for BM enabling with generic pci_dev_request_bus_master() function.
TEST=Able to boot to OS from sata device on CML platform.
Signed-off-by: Subrata Banik subrata.banik@intel.com Change-Id: Icd086184fd6fa9c03c806c857f13fad5a9e78a3e --- M src/soc/intel/common/block/sata/sata.c 1 file changed, 1 insertion(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/45320/1
diff --git a/src/soc/intel/common/block/sata/sata.c b/src/soc/intel/common/block/sata/sata.c index 1889700..7b234a9 100644 --- a/src/soc/intel/common/block/sata/sata.c +++ b/src/soc/intel/common/block/sata/sata.c @@ -4,17 +4,11 @@ #include <device/pci.h> #include <device/pci_ids.h>
-static void sata_final(struct device *dev) -{ - /* Set Bus Master */ - pci_or_config16(dev, PCI_COMMAND, PCI_COMMAND_MASTER); -} - static struct device_operations sata_ops = { .read_resources = pci_dev_read_resources, .set_resources = pci_dev_set_resources, .enable_resources = pci_dev_enable_resources, - .final = sata_final, + .final = pci_dev_request_bus_master, .ops_pci = &pci_dev_ops_pci, };